Chk fra #13
Chk fra #13
Conversation
ghost
self-assigned this
ghost
requested a review
from 
|
Please, update the description to tell reviewers what this is all about :) |
|
|
||
| #In case of error, comment this line |
There was a problem hiding this comment.
Why not leaving just the more "fixed" version git+https://github.com/martel-innovate/wifi.git@rpi-fix ?
there should be only one line per each module in the requirements.txt
| os.close(self.db_fd) | ||
| os.unlink(self.db_name) | ||
|
|
||
| def test_0a_disable(self): | ||
| time.sleep(20) |
There was a problem hiding this comment.
When you have to do the same at the beginning of all your tests... who do you call?
| ifaces = core.interfaces() | ||
| self.assertIsInstance(ifaces, list) | ||
| self.assertNotIn(self.iface, ifaces) | ||
| self.assertIn(self.iface, ifaces) |
There was a problem hiding this comment.
Do we have an explanation for this maybe? a comment or something would help. Same for the change in test below.
| self.assertTrue(len(psk) > 0) | ||
| self.assertTrue(len(ssid) > 0) | ||
| channel, psk, ssid = options.get('wireless-channel'), options.get('wpa-psk'), options.get('wpa-ssid') | ||
| if channel is not None: |
There was a problem hiding this comment.
Some things to comment here:
- What is it exactly that you want to test? E.g, if channel is not defined, should the test fail or not?
- Tests should not be printing much stuff to output, but rather passing quietly or failing with error messages.
- Avoid re-doing the same questions.
| @@ -36,16 +36,19 @@ def setUp(self): | |||
| self.gps_inf = -1000.0 | |||
|
|
|||
| def tearDown(self): | |||
| time.sleep(20) | |||
| @@ -0,0 +1,12 @@ | |||
| language: python | |||
There was a problem hiding this comment.
Oops, from this point onwards, looks like you committed the wifi repo within eWine-connectivity-manager repo. Revert this please.
rpi_y_w